Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initialized stats.py #414

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

Conversation

joeyouss
Copy link
Contributor

initialized stats.py and added some lines of code on which howdoi/sta…

@joeyouss
Copy link
Contributor Author

joeyouss commented Sep 8, 2021

@gleitz I cannot seem to understand the conflicts since the conflicts show only in text area, could you help me and also check this PR? it has a bunch of errors as of now but your reviews would help !

@gleitz
Copy link
Owner

gleitz commented Sep 8, 2021

Sure, happy to have a look.

If you check out this recent PR, you'll see that we now have a new function to fetch cache keys.

You can see the conflicts if you go to https://github.com/gleitz/howdoi/pull/414/conflicts or if, from your branch, you run git pull --rebase (assuming that you've set my howdoi master branch as the repo and branch you created your fork from). You can read more about rebasing at https://stackoverflow.com/questions/15602037/git-rebase-upstream-master-vs-git-pull-rebase-upstream-master

In any case, you'll just need to pull down the latest changes from my howdoi repo and change your function to call _get_from_cache(cache_key)

Screen Shot 2021-09-08 at 1 16 17 PM

@joeyouss
Copy link
Contributor Author

joeyouss commented Sep 8, 2021

Thanks ! I will take a look today for this

@joeyouss
Copy link
Contributor Author

So, here is the update:

  • the stats.py file works great but we do not have unit tests for it
  • rebase did not work for my laptop hence i added the function manually
  • once stats.py gets approved, we need to add termgraph dependencies in requirements.txt so that it gets installed everytime someone works on howdoi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants